search

0xPolygonHermez / cdk-erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
35 stars 39 forks source link

Refactor `SpawnStageBatches` function #1476

Closed Stefan-Ethernal closed 2 days ago

Stefan-Ethernal commented 1 week ago

The SpawnStageBatches is large (cdk-erigon/zk/stages/stage_batches.go at 1c66851ea12ffde9bf2c1ba0fc4c54d293635157 · 0xPolygonHermez/cdk-erigon ), which makes it hard to understand and maintain. Consider refactoring it into smaller, manageable, and easier-to-understand and maintain functions.

V-Staykov commented 4 days ago

This is already refactored and a lot shorter with the latest changes: https://github.com/0xPolygonHermez/cdk-erigon/blob/zkevm/zk/stages/stage_batches.go

hexoscott commented 2 days ago

Closing based on the recent refactor.