0xPolygonID / issuer-node

Privado ID Self-Hosted Issuer Node
Apache License 2.0
86 stars 81 forks source link

Schema validation in the issuer node is not providing clear error messages #667

Open roderik opened 3 months ago

roderik commented 3 months ago

Expected behaviour

Credential is issued

Actual behaviour

time=2024-06-12T14:09:32.439Z level=ERROR msg="validating credential subject" err="protected term redefinition: invalid JSON-LD syntax; tried to redefine a protected term"
time=2024-06-12T14:09:32.439Z level=ERROR msg="error saving the link" err="cannot parse claim"

Steps to reproduce the problem

I created the following credential via the public credential designer: https://schema-builder.polygonid.me/schemas/bbf8da01-b417-4349-84bb-eec622dc1d57

I can import it into the issuer (public and self managed), but when i try to issue it I get the error above (error 400 in the browser)

System information

Issuer node version: 0xpolygon/issuernode:7e0c661 OS & Version: k8s amd64 Browser & Version: Chrome/Safari

Logs (if needed)

time=2024-06-12T14:09:32.439Z level=ERROR msg="validating credential subject" err="protected term redefinition: invalid JSON-LD syntax; tried to redefine a protected term"
time=2024-06-12T14:09:32.439Z level=ERROR msg="error saving the link" err="cannot parse claim"

When submitting logs, please submit them as text and not as screenshots.

roderik commented 3 months ago

Ok, so it is not possible to call a field "issuer". It would be best to prevent this in the UI.

ottomorac commented 3 months ago

I see yes. This error would apply to both the issuer node and the schema builder I agree. We need better error messages.