0xPolygonID / issuer-node

Privado ID Self-Hosted Issuer Node
Apache License 2.0
86 stars 81 forks source link

Api doc in self hosted k8s config #669

Closed roderik closed 2 months ago

roderik commented 3 months ago

Expected behaviour

In the "Polygon ID - Issuer - UI API" api docs, the URL to the api is correct so try it works, when deployed to k8s with an ingress

Actual behaviour

CleanShot 2024-06-13 at 07 39 27@2x

Fix

In https://github.com/0xPolygonID/issuer-node/blob/main/api_ui/spec.html#L26 the url is set in the rapidoc settings While in https://github.com/0xPolygonID/issuer-node/blob/main/api/spec.html that works it is not I guess the js setter does not override it if it is set manually

The env vars in the config map i have are [redacted]

  ISSUER_API_ENVIRONMENT: local
  ISSUER_API_IDENTITY_BLOCKCHAIN: polygon
  ISSUER_API_IDENTITY_METHOD: polygonid
  ISSUER_API_IDENTITY_NETWORK: amoy
  ISSUER_API_UI_AUTH_PASSWORD: [redacted]
  ISSUER_API_UI_AUTH_USER: [redacted]
  ISSUER_API_UI_ISSUER_LOGO: https://[redacted].com/apple-icon.png
  ISSUER_API_UI_ISSUER_NAME: [redacted]
  ISSUER_API_UI_KEY_TYPE: BJJ
  ISSUER_API_UI_SCHEMA_CACHE: "false"
  ISSUER_API_UI_SERVER_PORT: "3002"
  ISSUER_API_UI_SERVER_URL: https://[redacted].com

I see that this value is used in the makefile, https://github.com/0xPolygonID/issuer-node/blob/7e0c6612a5b29cf48b1732ac5f5a89f12085e692/Makefile#L189 but that means it is not configurable at runtime from the container.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 20 days with no activity. Remove stale label, add the enhancement label or comment to avoid closing it in 10 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 10 days with no activity.