search

0xPolygonID / polygonid-flutter-sdk

Flutter Plugin to use the Polygon ID SDK
Apache License 2.0
40 stars 27 forks source link

auth claim nonce passed as parameter, default value if left blank #399

Closed plusema86 closed 5 months ago

gitguardian[bot] commented 5 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [5525172](https://dashboard.gitguardian.com/incidents/5525172?occurrence=130445802) | Triggered | Generic High Entropy Secret | aae4b204defd77b63226d715401d91a3e9542ea6 | lib/constants.dart | [View secret](https://github.com/0xPolygonID/polygonid-flutter-sdk/commit/aae4b204defd77b63226d715401d91a3e9542ea6#diff-e32d5555dcbfb615fa5808711c8d437da76ed26893cdf3c2c2004ff5817c529fL1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 22.59%. Comparing base (3471b60) to head (fc7b012).

Files Patch % Lines
...ta_sources/lib_pidcore_credential_data_source.dart 0.00% 3 Missing :warning:
...dential/libs/polygonidcore/pidcore_credential.dart 0.00% 2 Missing :warning:
...ial/data/data_sources/local_claim_data_source.dart 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #399 +/- ## =========================================== - Coverage 22.60% 22.59% -0.01% =========================================== Files 314 314 Lines 8768 8771 +3 =========================================== Hits 1982 1982 - Misses 6786 6789 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.