search

0xPolygonMiden / compiler

Compiler from MidenIR to Miden Assembly
MIT License
64 stars 22 forks source link

Use the tx kernel lib from `miden-base` for linking in `MidenTxKernelLibrary` #307

Open greenhat opened 2 months ago

greenhat commented 2 months ago

At https://github.com/0xPolygonMiden/compiler/blob/57e7b2e6f4d2655698a56c7086b899a2425c6e0a/sdk/base-sys/src/masl/tx.rs#L4

Rather than using the stubs, link the real tx kernel library from miden-base compiled at https://github.com/0xPolygonMiden/miden-base/blob/159d55a1e9f74dc8451b338076f87a1dfad9a179/miden-lib/build.rs#L66

bitwalker commented 2 months ago

As a note on this - where I'd like to go with these key Miden libraries, consists of a couple steps:

EDIT: Moved to #316

greenhat commented 2 months ago

Sounds great! Thanks for the thorough explanation. Your comment deserves to be an issue for miden toolchain.

bitwalker commented 1 month ago

Created #316 as the tracking issue for midenc toolchain