0xPolygonMiden / examples

Examples of using Polygon Miden
MIT License
18 stars 18 forks source link

Advice provider playground update #122

Closed frisitano closed 1 year ago

frisitano commented 1 year ago

This PR achieves the following:

TODO:

Call to action: It would be great if we could collaborative test the experience to ensure that the tests which have implemented are stabled.

Dominik1999 commented 1 year ago

@frisitano thanks a lot. That looks great. I left some nits and questions. And in general, I am not sure if we should allow those complex inputs like merkle_store in the playground. There is certainly no harm in doing so, but because you cannot create those data structures in the playground, I would expect users to use the CLI anyway for this.

And we need to change all the other examples as well because they don't work now anymore. I can do that after your PR is merged

frisitano commented 1 year ago

Thank you for the review!

And in general, I am not sure if we should allow those complex inputs like merkle_store in the playground. There is certainly no harm in doing so, but because you cannot create those data structures in the playground, I would expect users to use the CLI anyway for this.

I think it's quite important that we provide support for merkle data structures as they form the basis of a lot of useful applications as mentioned in my response above. However, I do agree that we need to build better support for actually building the merke store inputs.

And we need to change all the other examples as well because they don't work now anymore. I can do that after your PR is merged

I have a PR lined up for this: https://github.com/0xPolygonMiden/examples/pull/119/files

Dominik1999 commented 1 year ago

Thank you for the review!

And in general, I am not sure if we should allow those complex inputs like merkle_store in the playground. There is certainly no harm in doing so, but because you cannot create those data structures in the playground, I would expect users to use the CLI anyway for this.

I think it's quite important that we provide support for merkle data structures as they form the basis of a lot of useful applications as mentioned in my response above. However, I do agree that we need to build better support for actually building the merke store inputs.

And we need to change all the other examples as well because they don't work now anymore. I can do that after your PR is merged

I have a PR lined up for this: https://github.com/0xPolygonMiden/examples/pull/119/files

I am convinced, let's do that.