search

0xPolygonMiden / examples

Examples of using Polygon Miden
MIT License
18 stars 18 forks source link

Change `overflow_addrs` to being optional #130

Closed frisitano closed 1 year ago

frisitano commented 1 year ago

overflow_addrs should be notRequired() as we do not always need it to verify a proof. This PR modifies the yup schema to reflect this. This impacts proof verification and can be recreated using the advice_provider example.

Dominik1999 commented 1 year ago

I think the outputs are only going to be checked when the user wants to verify, right?

So do we need an overflow_addrs for every verification?

frisitano commented 1 year ago

I think the outputs are only going to be checked when the user wants to verify, right?

So do we need an overflow_addrs for every verification?

Yes that's correct and in some instances, like the advice_provider example, it's not needed for verification. This PR changes the requirement of overflow_addrs such that it is optional.