search

0xPolygonMiden / examples

Examples of using Polygon Miden
MIT License
18 stars 18 forks source link

feat: catching any input errors in the frontend #54

Closed Dominik1999 closed 1 year ago

Dominik1999 commented 1 year ago

Closes #18

Dominik1999 commented 1 year ago

Hmm added a new formatter. Only changes to App.tsx are relevant for that PR. The rest is formatting.

I can change the PR only to contain the changes and then send a PR with the new formatting.

grjte commented 1 year ago

Hmm added a new formatter. Only changes to App.tsx are relevant for that PR. The rest is formatting.

I can change the PR only to contain the changes and then send a PR with the new formatting.

That would be great, thanks. It'll be easier to review & a cleaner git history to keep them separate

Dominik1999 commented 1 year ago

Thanks @Dominik1999! I didn't try running it up locally yet, so this review is just based on looking at the code. Once you've addressed these comments I can take a quick look at that too

Thanks for your review. Your points should be addressed by now. Let me know what you think.

I tested it locally, but we need to add proper testing to the whole playground, which will be reflected in the next PR - issue here https://github.com/0xPolygonMiden/examples/issues/28

Dominik1999 commented 1 year ago

I will rebase