search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 27 forks source link

Add ability to inject note args when consuming notes #207

Closed Dominik1999 closed 6 months ago

Dominik1999 commented 6 months ago

Users can define note args when consuming notes

As described in https://github.com/0xPolygonMiden/miden-base/issues/338, users can specify note args being put on top of the stack when a certain note is executed. This can be useful if a user only wants to partially consume the assets contained in a note, and the note script allows that.

We need support in the client to allow for note args injection

Users of the Miden client should be able to define and inject note args when consuming notes. Currently, we have note args together with the transaction script in the TransactionArgs struct.

Unclear yet what would be the best way to provide note args

Currently we only allow for a single Word in the note args. Later we might want to allow more data. So for now, we might be able to simply add note args optionally to the CLI transaction command.

Maybe we can discuss the best way forward here.

bobbinth commented 6 months ago

I think this and #203 are basically the same thing - i.e., we need a way to execute custom transactions and specify all relevant inputs for them.

Dominik1999 commented 6 months ago

OK, then, maybe let's close this issue in favor of #203 and I will re-write the issue