mFragaBA
commented
7 months ago Thank you! I left some comments above - but overall, I think we need to rethink the overall approach to this problem to come up with a more comprehensive solution.
yeap, the two approaches thought so far were:
- validate the script hash and transaction inputs: this has the downside that it'll only work for p2id and p2idr notes (with maybe some extra check)
- try consuming the notes in a transaction for each account: this could also have some problems since p2idr might be consumable at a point in the future but not necessarily at the moment of the check
Are there any other ways of enusring a note might be consumable by an account?
bobbinth
Dominik1999
addresses #131
When executing transactions, these transactions can create notes. If the notes are to be consumed by any of the accounts managed by the client, it makes sense to store them for execution (this means storing them in the
input_notestable). If not, we can avoid storing them (we still store them in theoutput-notestable).For now we'll handle P2ID and P2IDR notes as they're the only think we have. To check if we can consume them we just need to see that they have the corresponding script hash and the account id is the only note input.
I also implemented this as a function that belongs to the store trait which is implemented by default. This will make it more flexible for different stores to choose their own heuristic
I'd recommend merging this after #206 as there is introduced a test to ensure the note scripts are valid