search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 27 forks source link

refactor: make account id mandatory on cli command #230

Closed mFragaBA closed 5 months ago

mFragaBA commented 5 months ago

When you run miden-client account show without providing an argument it fails saying that it's not somethig supported yet. Talked to @igamigo and came to the conclusion we don't need this currently and it's better to remove it.

bobbinth commented 5 months ago

btw, a potentially nice feature to add could be support for setting a "default" account. this way, when account ID is not specified, all commands would go against that account. Let's create an issue for this (unless one exists already).

igamigo commented 5 months ago

btw, a potentially nice feature to add could be support for setting a "default" account. this way, when account ID is not specified, all commands would go against that account. Let's create an issue for this (unless one exists already).

Yeah, this was the original intent. Since it seemed low-priority I told Martin that this todo could go away until someone implemented it. I thought this was being tracked on an issue (or discussed as part of a bigger issue) but after a quick search I did not find it, going to create one now.