Review transaction status changes code on syncs

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup

MIT License

32 stars 27 forks source link

Review transaction status changes code on syncs #232

Closed igamigo closed 5 months ago

igamigo commented 5 months ago

Currently, we are not testing the process of marking the transactions as committed. This should happen based on incoming created input notes, incoming spent output notes and incoming account hash changes (although we don't have a type of transaction that does not either create nor consume notes).

mFragaBA commented 5 months ago

there was an issue with transactions getting marked as committed which is solved in #235. Also, we'll be testing on integration tests that the transaction gets committed on #221 (once it sends the transaction it does a sync until the tx gets committed)

igamigo commented 5 months ago

This was fixed as of #235.