search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
29 stars 25 forks source link

Utilize `FeltRng` as the RNG component #244

Closed igamigo closed 3 months ago

igamigo commented 3 months ago

What should be done?

FeltRng now implements RngCore and so we can use fill_bytes() from its API (done in https://github.com/0xPolygonMiden/crypto/pull/299 and v0.9.0 of miden-crypto has been released). After a new version of Miden VM is released and these changes are available to downstream crates we need to remove ClientRng and enforce only FeltRng for the RNG component of the Client.

How should it be done?

Remove ClientRng and make sure only FeltRng is utilized. Also we should confirm that this is the only source of randomness.

When is this task done?

After the RNG component of Client is FeltRng

Additional context

https://github.com/0xPolygonMiden/miden-client/pull/236#discussion_r1537709096

mFragaBA commented 3 months ago

Closing as #245 already got merged (the PR was missing the "Closes #ISSUE_NUMBER")