0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
29 stars 25 forks source link

Rework `NoteTag`-related functionality #265

Closed igamigo closed 3 months ago

igamigo commented 3 months ago

What should be done?

We should rework the client functions for adding and removing NoteTags to the store. Currently, there are only ways to add tags (with Client::add_tag()), but they take u64s. Furthermore, these store tags are not taken into account when syncing with the node (which only uses tags for all tracked client accounts).

How should it be done?

Client and store functions should take and return NoteTag, and the client should utilize tags for syncs.

When is this task done?

Additional context

No response

mFragaBA commented 3 months ago

closing this as #266 got merged