search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 29 forks source link

refactor: note tag rework #266

Closed mFragaBA closed 5 months ago

mFragaBA commented 5 months ago

closes #265

igamigo commented 5 months ago

Oh, also, let's add a tag on DB creation time for tag 0 (let's do it on store.sql). I think it makes sense to keep it there as we can imagine some clients might want to get rid of them. I wonder if we want to add account tags there as well, but let's not do that for now.

mFragaBA commented 5 months ago

Awesome, LGTM! Is there anything we can add to the unit tests to test tags? I'd like to not rely only on larger integration tests when possible.

I can add some unit tests that don't check notes during sync and just add, remove and list tags

Update: extended the test_add_tag to also test reming tags