search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
29 stars 25 forks source link

fix: change transaction commitment check for output notes #273

Closed tomyrd closed 2 months ago

tomyrd commented 3 months ago

Closes #252

One of the conditions to check if a transaction was commited or not is whether it's output notes are also commited. With the addition of onchain notes, the output notes created by a transaction may not be tracked by the client so we need to check with the node rpc endpoint to verify the note commitments.

tomyrd commented 2 months ago

Given what was discussed in #252 this PR was rendered unnecessary. The previous solution (which was commented) should work.