0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 29 forks source link

Clean up Clap usage #276

Closed igamigo closed 4 months ago

igamigo commented 5 months ago

What should be done?

There are a couple of things related to clap that we could clean up.

How should it be done?

Writing parsers for basic structs that we use on clap (as strings right now)

When is this task done?

When we can define our custom types on Clap commands.

Additional context

No response

mFragaBA commented 5 months ago

Right now we receive all parameters as strings but we should be able to set parsers for custom types (like AccountId), making the code a bit cleaner and the API clearer as well.

How would this interact with #274 and #196?

igamigo commented 4 months ago

Closed by #348