0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
27 stars 23 forks source link

Screen notes before deciding if block has relevant notes #279

Closed igamigo closed 1 month ago

igamigo commented 2 months ago

What should be done?

Right now, on a sync, we set the block's block_has_relevant_notes based on whether or not we received a block header with notes. Because tags are matched in a fuzzy manner, this might not always be necessary. We could utilize the note screener to check whether the notes are actually useful to use, and if we can confirm that none of them are, we can set block_has_relevant_notes to false.

How should it be done?

On the sync, we should set block_has_relevant_notes based on whether the note screener could confirm that no notes would be useful to the client. If any of them are unknown, we should default to saving it as relevant anyway.

When is this task done?

When the note screener defines whether the block has relevant notes.

Additional context

No response

mFragaBA commented 1 month ago

closing as #291 got merged