search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
27 stars 23 forks source link

re-export structs/enums used in the client's public API #280

Closed mFragaBA closed 1 week ago

mFragaBA commented 2 months ago

What should be done?

nowadays in order to use the client you need to add both miden-client and miden-object packages. We should instead do a re-export of structs and enums used in the public interface (such as AccountId for example)

How should it be done?

add the re-exports on lib.rs

When is this task done?

when you can create a new crate, and use the client only by adding miden-client as a dependency in Cargo.toml without the need of adding miden-objects as a dependency

Additional context

No response

igamigo commented 2 months ago

As discussed offline, as part of this we should remove enums such as the client's AccountStorageMode which is a duplicate of the miden-base one.

mFragaBA commented 1 week ago

394 got merged, should we close this? We'll probably need another iteration but it might deserve a second issue

igamigo commented 1 week ago

Yup, let's close