0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
27 stars 23 forks source link

feat: ask confirmation before submitting transaction #290

Closed mFragaBA closed 2 months ago

mFragaBA commented 2 months ago

closes #257

Summary of changes

Steps to test

You can start from either a fresh client or an existing one. To test this change, you can run any transaction (i.e miden-client tx new ...) and check that it asks for confirmation and it prints a summary of the changes applied to the account. Enusure that if you submit a "y" or "Y" the transaction gets proven and sent to the node, and doesn't do anything else otherwise (no state shall be changed in that case)

Here's how it would look like:

image

After confirmation:

image
mFragaBA commented 2 months ago

Looks great! Thank you!

Some thoughts for the future (not for this PR): seeing this now, we should probably add more info about the transaction (not just account delta). For example, something along the lines of "this transaction will consume notes a, b, c, have the following effects on the account, and produce notes x, y, z. Let's create an issue for this.

created #316