refactor: `Store` interior mutability + remove data store from `Client::new()`

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup

MIT License

32 stars 28 forks source link

refactor: `Store` interior mutability + remove data store from `Client::new()` #302

Closed igamigo closed 5 months ago

igamigo commented 5 months ago

Wraps the client's store over an Rc for shared ownership
This means that store now needs to handle interior mutability, which is why the SqliteStore wraps the SQL connection over a RefCell. Its API changes with this change to now always get &self.
Because we cannot implement DataStore for any Store due to the traits being in different crates, we keep ClientDataStore which now holds the Rc<S:Store>.

tomyrd commented 5 months ago

I tried to consume a note before doing a sync and the error message said that the note was already consumed. From what I gathered this happend because of this check. Maybe we should also check if the note is pending and show a different error.