0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 28 forks source link

feat: add better feedback to multiple commands #323

Closed tomyrd closed 4 months ago

tomyrd commented 4 months ago

addresses #314

Some commands had little to no feedback for the user in terms of the elements created/modified in some commands. This PR aims to complete the "Better Feedback messages" section of this summary.

Feedback changes:

I can change this if requested and add more specific information (like new note IDs, IDs of updated notes/accounts, etc,). The downside is that for a large sync then maybe there would be a lot of output.

tomyrd commented 4 months ago

Adding a screenshot of the new feedback:

image
bobbinth commented 4 months ago

Adding a screenshot of the new feedback:

Looks great! A couple of potential improvement suggestions:

  1. Would it be possible to split "Proving transaction and then submitting..." into "Proving transaction" and "Submitting transaction" lines? It would be awesome if there could be timing info attached to these. For example: "Proving transaction... done in 1.2 sec", "Submitting transaction to node... done in 0.2 sec". If that's difficult, we can tackle this as a separate issue.
  2. I would change "Output note IDs created" to just "Output notes:"