0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 28 forks source link

feat: add extra cli output for certain commands #326

Closed tomyrd closed 4 months ago

tomyrd commented 4 months ago

closes #314

This PR focuses on the last commands that needed improved output. Specifically:

Some screenshots: info command

image

notes list command

image

notes show command (with all flags)

image image image
mFragaBA commented 4 months ago

another thing (although idk if it's too relevant to show) we could add to the notes show command is whether the note is exportable or not

tomyrd commented 4 months ago

Is it possible that we're counting notes twice on the sync summary?

I'm counting the input and output notes as separate notes that were updated. So maybe if the same note is on both groups then it's counted twice.

mFragaBA commented 4 months ago

Is it possible that we're counting notes twice on the sync summary?

I'm counting the input and output notes as separate notes that were updated. So maybe if the same note is on both groups then it's counted twice.

Since we're kind of hiding the fact that we have input and output notes to the user, I think it's better to just talk about notes regardless of whether it's an input or output note. In that case we shouldn't count it twice. Otherwise we see on the sync summary that we updated more notes than what they see on the info