feat: Utilize expected notes from `ExecutedTransaction`

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup

MIT License

32 stars 28 forks source link

feat: Utilize expected notes from `ExecutedTransaction` #329

Closed igamigo closed 4 months ago

igamigo commented 4 months ago

Closes #320

Now that ExecutedTransaction contains all output note details, we can use that for checking that the notes that we expected were all correctly generated by the transaction, and after that tracking them accordingly.
This PR also contains a small refactor related to the NoteScreener's use of the Store. It removes the lifetime in favor of Rc.

igamigo commented 4 months ago

@bobbinth don't mind the integration tests failing too much (I think there could be a bug related to tags on miden-base, still investigating), but just want to see if these are about what you had in mind