Test suite improvements

igamigo commented 4 months ago

What should be done?

Improve the test suite.

How should it be done?

Bring our own genesis.toml for the node to use instead of utilizing the one shipped by miden-node. This would allow us to create the accounts we want and not depend on the node (eg, not fail when paths change in the other repo) (#321)
We should also test importing accounts from the node's genesis, and executing transactions with them. We currently do not do that (only importing/exporting accounts without more context).
It would be nice if we were to test the CLI, especially with commands related to IO like importing/exporting notes or accounts. We could use assert_cmd or something similar to issue cargo commands and test the CLI as well as the library.

When is this task done?

When the CLI is tested, we are testing executing transactions with imported accounts and we don't utilize the files shipped by the node. We can also discuss further improvements here.

Additional context

Initially I thought we were testing transactions with imported accounts, but this reported issue reminded me we don't.

mFragaBA commented 3 months ago

should we close this since #353 got merged? @igamigo

igamigo commented 3 months ago

Yes, good point! Closing as done by #353 and #321

0xPolygonMiden / miden-client