0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
25 stars 22 forks source link

refactor: simplify and separate note list #356

Closed tomyrd closed 1 month ago

tomyrd commented 1 month ago

closes #332

The notes --list command showed both input and output in the same table. The table was also a bit crowded. This PR fixes this by separating the notes into two side by side tables that only show the ID and status of a note. If the user wants to see more information about a certain note they can run miden notes --show <id>.

Additional fixes:

Screenshot of the new table (ignore the fact that some consumers are not known, that is the bug that was fixed):

image
bobbinth commented 1 month ago

Looks great! Thank you! From visual standpoint, it look a bit less intuitive than I originally imagined. I wonder if we could try a couple of different options:

  1. Make it look less like a table and more like two separate lists (still side-by-side). For example, we could combine ID and status into a single column.
  2. Maybe instead of side-by-side, we could put the lists one under the other (and still make it look less like a table and more like two separate lists).
tomyrd commented 1 month ago

I think I have a version that is more in line with your comment. These would be two possible versions:

Side-by-side:

image

One over the other:

image

I think I prefer the second one as the entries all get to be one line

bobbinth commented 1 month ago

I think I prefer the second one as the entries all get to be one line

Yeah - I like it better too. A couple of comments:

tomyrd commented 1 month ago

Something like this?

image
bobbinth commented 1 month ago

Something like this?

Yep - looks great!