0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
25 stars 22 forks source link

[Feature]: Standardise Makefile and CI across Miden repositories #357

Closed phklive closed 2 weeks ago

phklive commented 1 month ago

Feature description

To whom is this feature for?

Rollup operator

Why is is this feature needed?

For now we are using different configurations for the Makefile and CI across the Miden repositories.

We want to standardise this:

How is this feature used?

This will improve management of repositories

Why is this feature needed?

What do you think @igamigo

igamigo commented 1 month ago

What are the motivations for this? I It seems that most Miden repos use Cargo Make, and many switched from Make not long ago. I'm not opposed but I don't see advantages to switching back, except perhaps Make being more widely available (ie not having to install it separately on CI). I think most of the uses of Make that I've seen in Miden repos are based around having "aliases" of scripts to run, not really making much use of make targets. In this sense, I think Cargo Make is more expressive and declarative , and adjusts a bit better to some use-cases.

bobbinth commented 1 month ago

@phklive can probably add to this but the motivations are as follows:

  1. cargo make requires separate install in most cases. This means an extra step (and potential confusion) for users.
  2. cargo make takes non-negligible amount of time to install during CI runs (something like 1.5 mins, I believe). We can try to use a pre-compiled version cargo make, but it is not very widely used.
  3. cargo make sometimes has some default (and un-intuitive) behaviors, while make is pretty straight forward.
mFragaBA commented 2 weeks ago

closing as #359 got merged