0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
25 stars 22 forks source link

Adding Changes to Enable WASM-32 Support #378

Closed dagarcia7 closed 2 weeks ago

dagarcia7 commented 3 weeks ago

Summary of Changes

Once this PR is accepted and merged, I will follow up with another PR to officially add the wasm crate. Once this is checked in, we can work together to publish the wasm code as an NPM package so others can start using it in their web applications.

bobbinth commented 3 weeks ago

Looks great! Thank you! Overall, I agree with the plan:

  1. First, we'll merge #725 in miden-base. For this, @phklive will update the current implementation of winter-maybe-async macro and I'll publish the new crate.
  2. Then, we'll update this PR to remove code duplication. After that we'll merge this PR. a. Here, would also be great to get rid of async_trait dependency.
  3. Then, we'll merge #367 to clean up feature organization etc. a. For example, rather than having dedicated wasm feature, we might just have an async feature and gate all CLI-related dependencies behind the executable feature.
  4. After these are done, we can add the WASM crate in a separate PR.
bobbinth commented 3 weeks ago
  • First, we'll merge #725 in miden-base. For this, @phklive will update the current implementation of winter-maybe-async macro and I'll publish the new crate.
  • Then, we'll update this PR to remove code duplication. After that we'll merge this PR. a. Here, would also be great to get rid of async_trait dependency.
  • Then, we'll merge #367 to clean up feature organization etc. a. For example, rather than having dedicated wasm feature, we might just have an async feature and gate all CLI-related dependencies behind the executable feature.
  • After these are done, we can add the WASM crate in a separate PR.

The first item from this list is now complete. @dagarcia7 - could you start on the second item?

Dominik1999 commented 2 weeks ago

merge?