Closed dagarcia7 closed 2 weeks ago
Looks great! Thank you! Overall, I agree with the plan:
miden-base
. For this, @phklive will update the current implementation of winter-maybe-async
macro and I'll publish the new crate.async_trait
dependency.wasm
feature, we might just have an async
feature and gate all CLI-related dependencies behind the executable
feature.
- First, we'll merge #725 in
miden-base
. For this, @phklive will update the current implementation ofwinter-maybe-async
macro and I'll publish the new crate.- Then, we'll update this PR to remove code duplication. After that we'll merge this PR. a. Here, would also be great to get rid of
async_trait
dependency.- Then, we'll merge #367 to clean up feature organization etc. a. For example, rather than having dedicated
wasm
feature, we might just have anasync
feature and gate all CLI-related dependencies behind theexecutable
feature.- After these are done, we can add the WASM crate in a separate PR.
The first item from this list is now complete. @dagarcia7 - could you start on the second item?
merge?
Summary of Changes
wasm
feature flag and added conditional rendering everywhere where async will be needed for WASM.maybe-async-await
macro as Paul-Henry has done in themiden-base
repository.Cargo.toml
file where I tried to organize the dependencies based on whether thewasm
feature flag and thetarget_arch
iswasm32
or not.Once this PR is accepted and merged, I will follow up with another PR to officially add the wasm crate. Once this is checked in, we can work together to publish the wasm code as an NPM package so others can start using it in their web applications.