search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
25 stars 22 forks source link

feat: use transaction summary and nullifier update from sync response #387

Closed mFragaBA closed 1 week ago

mFragaBA commented 2 weeks ago

closes #386

mFragaBA commented 1 week ago

LGTM! I think this is covered by most of the integration tests already, but it might be good to test the new behavior (meaning the effect of executing more than one transaction, and seeing that all get updated to committed correctly). Not for this PR but we should likely track this.

I've just pushed a new integration test that verifies that we can sync with multiple transactions getting committed (and belonging to different blocks) and their block height are set to different values