in a recent miden-client PR, this ticket was filed in the miden-node repo https://github.com/0xPolygonMiden/miden-node/issues/388. Once this is complete and the miden-node-proto crate is able to be used as a dependency for both WASm and non-WASM targets, we can go ahead and remove some obsolete code that was added to the miden-client crate as a workaround to get the crate to compile for WASM targets.
How should it be done?
The dep:miden-node-proto can be removed from the list of dependencies for the tonic feature
The error code gated under the tonic feature can be removed this using statement use miden_node_proto::errors::ConversionError; can be compiled at all times
hex, prost, and thiserror can be removed as dependencies from the Cargo.toml file.
When is this task done?
This task is done when https://github.com/0xPolygonMiden/miden-node/issues/388 is merged and released in the miden-node repository, and when you can successfully pull in the miden-node-proto crate for both WASM and non-WASM targets. Additionally, the workaround code that was added in the meantime is removed.
What should be done?
As a result of these two discussions
in a recent
miden-clientPR, this ticket was filed in themiden-noderepo https://github.com/0xPolygonMiden/miden-node/issues/388. Once this is complete and themiden-node-protocrate is able to be used as a dependency for both WASm and non-WASM targets, we can go ahead and remove some obsolete code that was added to themiden-clientcrate as a workaround to get the crate to compile for WASM targets.How should it be done?
dep:miden-node-protocan be removed from the list of dependencies for thetonicfeaturetonicfeature can be removed this using statementuse miden_node_proto::errors::ConversionError;can be compiled at all timeshex,prost, andthiserrorcan be removed as dependencies from theCargo.tomlfile.When is this task done?
This task is done when https://github.com/0xPolygonMiden/miden-node/issues/388 is merged and released in the
miden-noderepository, and when you can successfully pull in themiden-node-protocrate for both WASM and non-WASM targets. Additionally, the workaround code that was added in the meantime is removed.Additional context
Related discussions in recent miden-client PR