search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
25 stars 22 forks source link

Note importing process follow-ups #405

Open igamigo opened 4 days ago

igamigo commented 4 days ago

Some things to fix came up when testing #375:

There are some minor issues to revisit but I think overall it's working as expected and we can tackle them in a follow up PR:

  • note should show whether it is ignored or not (easier for the user of the CLI to track)
  • if I export a committed note as partial, then I consume it and I import it in another client, the note goes from Expected > => Committed but never gets marked as consumed
  • also, every sync says: 
    2024-06-28T18:57:40.207197Z  WARN miden_client::client::sync: Current partial MMR already contains the requested data
State synced to block 167
New public notes: 0
Tracked notes updated: 1
Tracked notes consumed: 0
Tracked accounts updated: 0
Commited transactions: 0
  • ... but no notes got actually updated
  • this only happens for partial notes, since full notes are never ignored and id notes can't be imported (if they're private)
  • I tried exporting a public committed note with export type id, then consumed the note, then imported it in another client and it failed.

Originally posted by @mFragaBA in https://github.com/0xPolygonMiden/miden-client/pull/375#pullrequestreview-2148792711

However, some of this might depend on how we rework the note importing workflow.