search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
25 stars 22 forks source link

refactor: split cli and client into workspace #407

Closed tomyrd closed 1 day ago

tomyrd commented 4 days ago

This PR restructures the repo to separate the client and cli in separate crates sharing a workspace.

bobbinth commented 4 days ago

btw, how is this PR different from #400?

igamigo commented 4 days ago

btw, how is this PR different from https://github.com/0xPolygonMiden/miden-client/pull/400?

It's not, that PR was originally @mFragaBA's attempt which was behind in the commit history. Eventually it was decided that it was better to start from a fresh branch off of next which resulted in this other PR. I closed that first one.

mFragaBA commented 4 days ago

We debugged offline for a while on why the integration tests were failing (assert_cmd wasn't finding the CLI binary). We noticed the CLI binary was not being built. As a fast fix we noticed that you can just run make build before the tests and that'd be enough. Now we're seeing if adding the CLI as a dev-dependency also forces the build on the CLI and it gets found.

UPDATE: including it as a dependency didn't work so we'll go with building before running the test