addresses #391. (The PR is already reviewable but we'll refrain merging until #409 gets merged to reduce iteration cycles).
In some tests we do some assertions with client.get_input_notes(filter).unwrap() and checking the length of it. While in most cases that is enough, it will sporadically fail If the node running the integration test has public notes belonging to another account with the same account id prefix (the one used to create the note tag). In order to mitigate it, we do a filter by account_id to ensure the note we want is there (there might be others, we won't care too much). In the case of swap tests, I also used get_consumable_notes since in that situation we wanted to consume the notes anyways.
addresses #391. (The PR is already reviewable but we'll refrain merging until #409 gets merged to reduce iteration cycles).
In some tests we do some assertions with
client.get_input_notes(filter).unwrap()and checking the length of it. While in most cases that is enough, it will sporadically fail If the node running the integration test has public notes belonging to another account with the same account id prefix (the one used to create the note tag). In order to mitigate it, we do a filter by account_id to ensure the note we want is there (there might be others, we won't care too much). In the case of swap tests, I also usedget_consumable_notessince in that situation we wanted to consume the notes anyways.