0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
27 stars 23 forks source link

Move CLI integration tests inside the `miden-cli` crate #411

Closed tomyrd closed 6 days ago

tomyrd commented 1 week ago

What should be done?

Right now we need to build the binary inside the integration-test makefile rule. This is because the tests inside cli_tests.rs use the binary. We should move the CLI tests that use assert_cmd inside the miden-cli crate so that the tests crate doesn't require to build the binary.

How should it be done?

Internal crate tests should be created inside miden-cli that use the assert_cmd to directly use the binary. These tests are already written iniside tests/integration/cli_tests.rs.

When is this task done?

The task is done when:

Additional context

Comment where we talk about the temporary fix of building the binary before the integration tests.

tomyrd commented 1 week ago

Per this comment we should try to remove the integration feature if possible

tomyrd commented 6 days ago

closed by #413