Closed mFragaBA closed 3 months ago
- If the transaction involves any unauthenticated notes, their IDs should be included in the
NoteId
toinput_notes: Option<NoteArgs>
. If not, this should be an error (or should we include it automatically?).
This is already done so in the constructor of TransactionRequest
- We could also check that any notes that are not in the
unauthenticated_input_notes
list has aninclusion_proof
in our local Store.
Would it be ok to do it in Client::new_transaction
, before calling tx_executor.execute_transaction
?
Would it be ok to do it in
Client::new_transaction
, before callingtx_executor.execute_transaction
?
Yeah, I think this would be the place to do it.
Do you think we will get this into today's release?
Do you think we will get this into today's release?
Yeah, this should make it in. It should be merged within the next few hours hopefully.
addresses #418
Steps to test
polydez-unauth-notes
branchI tested a few flows consisting of a combination of:
TODO