0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
32 stars 28 forks source link

feat: enable consumption of unauthenticated notes #417

Closed mFragaBA closed 3 months ago

mFragaBA commented 3 months ago

addresses #418

Steps to test

I tested a few flows consisting of a combination of:

TODO

mFragaBA commented 3 months ago
  • If the transaction involves any unauthenticated notes, their IDs should be included in the NoteId to input_notes: Option<NoteArgs>. If not, this should be an error (or should we include it automatically?).

This is already done so in the constructor of TransactionRequest

  • We could also check that any notes that are not in the unauthenticated_input_notes list has an inclusion_proof in our local Store.

Would it be ok to do it in Client::new_transaction, before calling tx_executor.execute_transaction?

igamigo commented 3 months ago

Would it be ok to do it in Client::new_transaction, before calling tx_executor.execute_transaction?

Yeah, I think this would be the place to do it.

Dominik1999 commented 3 months ago

Do you think we will get this into today's release?

igamigo commented 3 months ago

Do you think we will get this into today's release?

Yeah, this should make it in. It should be merged within the next few hours hopefully.