add flag to input_notes table to distinguish between authenticated and unauthenticated notes

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup

MIT License

27 stars 23 forks source link

add flag to input_notes table to distinguish between authenticated and unauthenticated notes #420

Open mFragaBA opened 6 days ago

mFragaBA commented 6 days ago

I think this is fine for now, but in the future we should probably have some sort of a way of telling whether it is OK for a note to be unauthenticated (e.g., maybe via a database flag). Let's create an issue for this.

_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-client/pull/417#discussion_r1665974128_

mFragaBA commented 5 days ago

Forgot to mention, but the benefit of this is that we could differentiate Authenticated and Unauthenticated input notes during the get_transaction_inputs function from DataStore. (there is already some logic there to check the existence of inclusion proofs and note status so currently after #417 that logic will be split in two places)