split `TransactionRequest` code into `TransactionRequest` and `TransactionRequestBuilder`

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup

MIT License

32 stars 28 forks source link

split `TransactionRequest` code into `TransactionRequest` and `TransactionRequestBuilder` #426

Closed mFragaBA closed 2 months ago

mFragaBA commented 3 months ago

Not for this PR, but we should consider refactoring this into more like a "builder"-style API. Let's create an issue for this.

_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-client/pull/417#discussion_r1666555607_

bobbinth commented 3 months ago

It doesn't have to be two separate structs - could still be just one TransactionRequest but instead of one constructor that takes all parameters, we could have a few constructors which can be chained to build the transaction request.

bobbinth commented 2 months ago

Closed by #434.