search

0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup
MIT License
39 stars 29 forks source link

refactor: Remove `serde` #458

Open SantiagoPittella opened 3 months ago

SantiagoPittella commented 3 months ago

What should be done?

We should remove the serde dependency as is no longer needed. We should be able to use our implementations of (de)serialize.

How should it be done?

Replace serde with our own implementations.

When is this task done?

When serde is no longer a required dependency is the repository.

Additional context

No response

igamigo commented 3 months ago

As part of this, we should also remove the serde feature flags from the miden-base dependencies that we use. Also, I think the web client might still need serde for the wasm bindgen code but we should be able to remove it from the main crate.

bobbinth commented 3 months ago

As part of this, we should also remove the serde feature flags from the miden-base dependencies that we use.

Yeah - I think it was there primarily to support serialization for tests (which I think is no longer relevant) and to support the client. If the client no longer needs serde, then this should be removed from miden-base as well.

SantiagoPittella commented 2 months ago

This issue was partially addressed in https://github.com/0xPolygonMiden/miden-client/pull/514 . A few more structures and enums should remove serde yet, but in that version we aimed to be compatible with https://github.com/0xPolygonMiden/miden-base/pull/838 .