0xPolygonMiden / miden-client

Client library that facilitates interaction with the Miden rollup

MIT License

39 stars 30 forks source link

Closed dagarcia7 closed 2 weeks ago

dagarcia7 commented 3 weeks ago

Summary

This PR adds integration tests for the get_transactions and compile_tx_script web client calls in transactions.rs.

igamigo commented 3 weeks ago

Once https://github.com/0xPolygonMiden/miden-base/pull/951 gets merged, the CI can be re-run since the WASM build should be fixed

dagarcia7 commented 3 weeks ago

@igamigo sounds good thanks for the heads up! In the meantime, the rest of the feedback has been addressed @tomyrd @SantiagoPittella 🙌

igamigo commented 2 weeks ago

@dagarcia7 can you rebase your fork from next? It should contain fixes to your failing tests (as of #556).

dagarcia7 commented 2 weeks ago

@igamigo rebased and all looks good now! 🙌 Thanks!