In #559 we changed the way NoteFilter::List behaved when it didn't find every listed note. Originally it returned an error but in that PR we changed it so that it just returned an incomplete list. The sqlite store was updated but we didn't remove the error from the idxdb store.
Where the notes returned by the node may or may not exist in the store. Depending on the state of the node at a given moment, it may return notes that are not relevant to the client.
In #559 we changed the way
NoteFilter::Listbehaved when it didn't find every listed note. Originally it returned an error but in that PR we changed it so that it just returned an incomplete list. The sqlite store was updated but we didn't remove the error from the idxdb store.The test was flaky because it was failing here: https://github.com/0xPolygonMiden/miden-client/blob/db8454a08b8e8723b8e7b6cf7a77b7c78c036f0c/crates/rust-client/src/sync/mod.rs#L290-L294
Where the notes returned by the node may or may not exist in the store. Depending on the state of the node at a given moment, it may return notes that are not relevant to the client.