0xPolygonMiden / miden-node

Reference implementation of the node for the Polygon Miden rollup
MIT License
53 stars 37 forks source link

Added transaction number limit and updated tests to the limits introduced in `miden-objects` #503

Closed polydez closed 1 month ago

polydez commented 1 month ago

Resolves issue https://github.com/0xPolygonMiden/miden-base/issues/398

Here we use the latest miden-objects with updated/new limits. Also implemented checking for limits we can't check in miden-objects. And also updated tests to the latest miden-object and added at least one asset in note mockups.

bobbinth commented 1 month ago

Not a full review, but as I mentioned in the miden-base PR, what we want to limit is not the number of transactions per batch/block, but rather the number of updated accounts.

A nice side effect of this should be an incentive to put transactions which touch the same account into a batch/block.