0xPolygonMiden / miden-vm

STARK-based virtual machine
MIT License
630 stars 160 forks source link

Update logging messages in the VM #1235

Closed Fumuran closed 8 months ago

Fumuran commented 9 months ago

This small PR updates the formatting of the logging messages in the VM to be in the same style with logging messages from Winterfell.

Fumuran commented 9 months ago

I'm wondering should we add a new command to make to make enabling tracing-forest feature more convenient? Make it similar to the FEATURES_CONCURRENT_EXEC, but with tracing-forest feature. Something like:

FEATURES_LOG_TREE=--features concurrent,executable,tracing-forest

exec-tree:
    cargo build $(PROFILE_OPTIMIZED) $(FEATURES_LOG_TREE)
bobbinth commented 9 months ago

I'm wondering should we add a new command to make to make enabling tracing-forest feature more convenient? Make it similar to the FEATURES_CONCURRENT_EXEC, but with tracing-forest feature. Something like:

Good idea! I'd probably call it exec-info. Also, would we not need to set log level to INFO for it to work?

Fumuran commented 8 months ago

Also, would we not need to set log level to INFO for it to work?

No, there is no need to change the default log level, we specify it on the execution stage, so the only thing we need to change is a Makefile