search

0xPolygonMiden / miden-vm

STARK-based virtual machine
MIT License
615 stars 152 forks source link

Fix duplicate procedure name issue. #1256

Closed Fumuran closed 3 months ago

Fumuran commented 6 months ago

Currently if we try to compile two programs in one context, which contain procedures with the same names, this will lead to a DuplicateProcName error. However we need to be able to do so while compiling transaction with multiple notes. To achieve this, error was replaced with a warning log message. This change should not lead to any issues with procedures parsing, compilation and execution.

Related issue: https://github.com/0xPolygonMiden/miden-base/issues/443

plafer commented 3 months ago

@Overcastan are you still working on this?

bobbinth commented 3 months ago

This may have been fixed by #1277. cc @bitwalker.

bitwalker commented 3 months ago

I know that #1277 will raise an error if you try to define duplicate procedures in the same module, or try to compile a module graph with duplicate modules, so I believe this is solved as of the merge of #1277.

bobbinth commented 3 months ago

Closing as superseded by #1277.