Integrate new `ilog2` and `cto` instructions into MMR

0xPolygonMiden / miden-vm

STARK-based virtual machine

MIT License

615 stars 152 forks source link

Integrate new `ilog2` and `cto` instructions into MMR #1269

Closed Fumuran closed 5 months ago

Fumuran commented 5 months ago

After implementation of the new ilog2 and cto instructions it became possible to use them directly in the implementation of the MMR. This PR removes the special implementations of ilog2 and cto instructions in the MMR and uses identical assembly instructions instead.

bobbinth commented 5 months ago

One question: does this break anything in miden-base (i.e., because MAST roots are now different)? (i don't think it should, but would be good to double-check)

Fumuran commented 5 months ago

I checked: no, it doesn't break anything, I managed to build the miden-base repo and successfully run all tests.