Closed cf closed 2 months ago
@cf - thank you for flagging this! Sorry for not looking into it earlier - we were migrating from the ministark
-based implementation to miden-gpu
-based implementation over the last few weeks.
@TheMenko - is the issue brought up here fixed in #1310?
Ah, i forgot about this issue. I just tested it with miden-gpu and the bug is still present @bobbinth
@cf - I just merged #1310 into the next
branch. Would you be able to rebase your PR from the latest next
?
Superseded by #1353.
Describe your changes
build_segments
by implementing a custombuild_aligned_segements
which usespage_aligned_uninit_vector
to allocate the segment data (instead of theuninit_vector
function used in winterfell's [original implementation])(https://github.com/facebook/winterfell/blob/23eb7132c60ab4132eefbfac117fe1fc55f02171/prover/src/matrix/segments.rs#L67)Original bug writeup: https://gist.github.com/cf/f5d582319d62ed0d7a7751c2001b6301/