Prepare for migration to next release of Miden crypto

0xPolygonMiden / miden-vm

STARK-based virtual machine

MIT License

612 stars 150 forks source link

Prepare for migration to next release of Miden crypto #1287

Closed Al-Kindi-0 closed 3 months ago

Al-Kindi-0 commented 3 months ago

Describe your changes

Mostly no-std issues and Falcon DSA.

Checklist before requesting a review

Repo forked and branch created from next according to naming convention.
Commit messages and codestyle follow conventions.
Relevant issues are linked in the PR description.
Tests added for new functionality.
Documentation/comments updated according to changes.

bobbinth commented 3 months ago

miden-crypto v0.9.0 is now on crates.io.

Al-Kindi-0 commented 3 months ago

miden-crypto v0.9.0 is now on crates.io.

Updated the PR accordingly. There is a clippy warning which I am not not sure about the best way to handle it.

bitwalker commented 3 months ago

There is a clippy warning which I am not not sure about the best way to handle it.

I would add a #[allow(dead_code)] annotation on that field for now, but if it is truly never read, then it can probably just be removed entirely, along with any code that writes to it.