search

0xPolygonMiden / miden-vm

STARK-based virtual machine
MIT License
611 stars 148 forks source link

CI: Add `cargo clippy` with the `executable` feature #1354

Open plafer opened 3 weeks ago

plafer commented 3 weeks ago

Most of the code under miden/ is behind the executable feature flag, and isn't nor cargo clippyd by our CI. We should probably add --all-features to our clippy check.

https://github.com/0xPolygonMiden/miden-vm/pull/1349#discussion_r1639712119

bobbinth commented 3 weeks ago

We should update CI jobs and Makefile here to follow what we've done in miden-base. @phklive - could you help with this?

plafer commented 3 weeks ago

Also, the integration tests in miden/tests/ are not executed on the CI.

phklive commented 2 weeks ago

We should update CI jobs and Makefile here to follow what we've done in miden-base. @phklive - could you help with this?

Sure, will make sure to add this in the CI and makefile.

phklive commented 2 weeks ago

Also, the integration tests in miden/tests/ are not executed on the CI.

Let me look into it.