search

0xPolygonMiden / miden-vm

STARK-based virtual machine
MIT License
615 stars 152 forks source link

Optimize truncate_stack procedure #1384

Closed Fumuran closed 1 month ago

Fumuran commented 1 month ago

This small PR changes the implementation of the sys::truncate_stack procedure in the stdlib to make it more efficient, as it was described in the related issue: https://github.com/0xPolygonMiden/miden-vm/issues/1334.

bobbinth commented 1 month ago

Also - let's update the changelog.

And a question: do we already have good tests covering this procedure?

Fumuran commented 1 month ago

In the changelog should I write about change in cycle count and number of locals?

I think that tests for this procedure are fairly decent: we have both basic test and a proptest here.

bobbinth commented 1 month ago

In the changelog should I write about change in cycle count and number of locals?

I would just say something like "Optimized std::sys::truncate_stuck procedure".