0xPolygonMiden / miden-vm

STARK-based virtual machine
MIT License
632 stars 161 forks source link

Serialize decorator data at the end #1531

Open yasonk opened 1 month ago

yasonk commented 1 month ago

Describe your changes

Moving all decorator data to the end in order to enable truncating it later. See issue #1489

Contains a minor refactor to make writing decorator info more direct by reducing interconnected layers of indirection. Also extracted some functions from the Serializer code to make it easer follow.

Checklist before requesting a review

yasonk commented 2 days ago

Rebased and started signing commits. But I don't think I can sign older commits.

yasonk commented 1 day ago

@PhilippGackstatter I addressed the last 4 comments. Thank you for the great suggestions in all cases!

PhilippGackstatter commented 1 day ago

@yasonk Thanks for the updates and signing commits!

I think just two more things to make CI happy:

You can try locally if the no-std build works without issues using make build-no-std.

@plafer Should we go ahead and merge after that or do you want to take another look?

bobbinth commented 1 day ago

@plafer Should we go ahead and merge after that or do you want to take another look?

Let me do a quick review. I'll try to do this on Friday.