0xPolygonMiden / miden-vm

STARK-based virtual machine
MIT License
632 stars 161 forks source link

Fix block stack table #1557

Closed plafer closed 3 weeks ago

plafer commented 3 weeks ago

Fixes block stack table (once again).

The problem this time was that the code that removed a row (on RESPAN or END) would always read the IS_CALL and IS_SYSCALL flags, which are only valid on an END operation. The blake3 benchmark happened to have a RESPAN operation with a few RESPANs that had a 1 in one of these rows. The fix is then to completely separate these 2 code paths.

I confirmed that all miden-base tests pass.